NativeScript / NativeScript/ios

Object.prototype.toString.apply(value) is not returning the proper constructor name

Open
#68 0 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
150
Forks
43
Avg merge
3d 10h
Merged PRs (30d)
22

Description

  • Please note this is unconfirmed

One of my plugins broke and the reason the user figured out was that it wasn't returning the proper constructor name with a Object.prototype.toString.apply(value) so their fix was to use InstanceOf to do the tests. However, this did work in the JSC engine, so for compatibility we should double check that this is broken and/or the return value.

I just wanted to make sure to make note of it so it will show up for me to test / fix at a later time. 😀

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.