NativeScript / NativeScript/ios

Navigation Memory leak

Open
#135 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
150
Forks
43
Avg merge
3d 10h
Merged PRs (30d)
22

Description

ns-v8ios since version 7 I think have this issue. Where garbage collector is not operating as intended. I think there's a duplicate about this topic in the issue list, but it's easier to create one for myself with all necessary details.

So the leak is happening even on the app that you can install with ns create. If you create one using the template where this code exists

Frame.topmost().navigate({
    moduleName: componentRoute,
    transition: {
      name: 'fade',
    },
})

I've tried to modify it in a way to use util GC(). It helped, by a tiny bit, but it's still not enough. I've made a video where I profile hello world app on iPhone and show on screen what is happening on my device. I'm basically jumping between template heavy pages that have bunch of

<GridLayout class="page__content">
        <Label class="page__content-icon far" text="&#xf1ea;"></Label>
        <Label class="page__content-placeholder" text="<!-- Page content goes here -->"></Label>
</GridLayout>

duplicated. On one page 300 lines, on the second one 6000 lines. And it's clearly visible that memory is being released by accumulates much much more.
Why so much lines is just to display that GC is clearly broken, but even in live app that I have, I have "complex" layouts because we're using NS-Vue and components approach create a lot of templates, even if they are flat. So our app crashing our clients devices quite easily, especially the ones that have only 2-3GB of RAM and the solution to make design more flat might not be a solution for us at all, unfortunately.

Version of xcode: 13.1
Version of ns-cli: 8.1.4
Version of ns-core: 8.1.1
Version of ios-runetime: 8.1.0

We would like to "invest" into this problem, to fix it ASAP, as our product suffers from this.

Here's there link to a video where I show the error https://drive.google.com/file/d/1Qz8jYFE6N4TVvS0G_8rrvmVzUe-KtKFC/view?usp=sharing

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in an app created with the ns create template, using the Frame.topmost().navigate example and the iOS, ns-cli, ns-core, and ios-runtime versions listed. Profile navigation between the described pages on an iPhone and compare memory behavior with and without the attempted GC() change. Done means the navigation leak is fixed and memory no longer accumulates until the app crashes.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, javascript
Domain
mobile-dev, performance
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.