NativeScript / NativeScript/ios-device-lib

Purpose of the IOSDeviceLib's interface

Open
#30 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
16
Forks
8
Avg merge
19h 29m
Merged PRs (30d)
2

Description

If we would like to state the following:

  • "The node code is there to be able to act as a proxy between the spawned process and the rest of the code"
    If this is true.. functions like upload,download, postNotifications should not be defined in the javascript code.

  • "The node code should serve as both proxy and api to be used from applications"
    If this is true... named functions are a nice idea.
    What seems wrong is the fact that currently the only ways to find what to pass in the uploadArray, downloadArray or postNotificationArray are to take a look at the mobile-cli-lib or go to the native code to see how we are parsing the array.

It seems the purpose of IOSDeviceLib's interface is not clear enough with the current implementation.
Please correct me if I don't understand correctly.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the JavaScript interface with the mobile-cli-lib usage and the native code that parses uploadArray, downloadArray, and postNotificationArray. Clarify whether IOSDeviceLib is intended as a proxy or an application-facing API, then define the interface changes needed to make that purpose and the accepted arguments explicit.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, javascript
Domain
api
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.