NativeScript / NativeScript/firebase
Expost remove listeners for firebase messaging
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 62
- Forks
- 53
- Avg merge
- 8d 4h
- Merged PRs (30d)
- 2
Description
When listening to onMessage, onNotificationTap there is no way to remove listeners and is leading to memory leak
// on message
firebase()
.messaging()
.onMessage(async (remoteMessage) => {
console.log({ remoteMessage });
});
// on notification tap
firebase()
.messaging()
.onNotificationTap((message) => {
console.log({ message });
});
there is no way to remove listeners as there is for firebase auth
firebase().auth().addAuthStateChangeListener
firebase().auth().removeAuthStateChangeListener
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the messaging implementations for onMessage and onNotificationTap, then inspect how each listener is registered and retained. The work is done when both APIs provide a way to remove their listeners, comparable to the authentication listener example, and the existing messaging behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- firebase, typescript
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100