NativeScript / NativeScript/firebase
[auth][android] signOut return undefined
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 62
- Forks
- 53
- Avg merge
- 8d 4h
- Merged PRs (30d)
- 2
Description
Hello @NathanWalker and @triniwiz
The signOut on android return undefined instead of boolean! the workaround is fixed by adding async await but this will force us to change the return type to Promise! and if we did we should doing same for IOS as well.
What do you think ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/firebase-auth/index.android.ts around line 1398, where the issue reports the Android signOut return value. Compare the Android behavior with the iOS implementation and confirm the intended boolean versus Promise contract; done means the platform APIs return the agreed value consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, typescript
- Domain
- authentication, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100