NativeScript / NativeScript/firebase

[@nativescript/firebase-messaging-core] denying notification permission returns error on Android

Open
#173 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
62
Forks
53
Avg merge
8d 4h
Merged PRs (30d)
2

Description

When you press "don't allow" on notification permission, promise returns an error. I guess it should return success with result AuthorizationStatus.DENIED?

https://github.com/NativeScript/firebase/blob/main/packages/firebase-messaging-core/index.android.ts#L318

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at packages/firebase-messaging-core/index.android.ts around line 318 and inspect how a denied notification-permission request is converted into the promise result. Confirm the expected AuthorizationStatus.DENIED behavior, then verify that pressing "don't allow" resolves successfully with that status rather than returning an error.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, typescript
Domain
mobile-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.