NativeScript / NativeScript/angular

My types are gone

Open
#163 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
55
Forks
13
Avg merge
16m
Merged PRs (30d)
1

Description

Hello together,
I am just trying to migrate to NS9 and Angular 21. However, unfortunately it seems like some types I need are gone. Would it be possible to add them to the exports? Seems like the mjs files do not export them
Here the relevant imports from the old package
import {
BackNavigationOptions,
ExtendedNavigationBehaviorOptions,
ExtendedNavigationExtras
} from '@nativescript/angular/lib/legacy/router/router-extensions';

ns --version
9.0.2

"dependencies": {
	"@angular/animations": "21.1.0",
	"@angular/common": "21.1.0",
	"@angular/compiler": "21.1.0",
	"@angular/core": "21.1.0",
	"@angular/forms": "21.1.0",
	"@angular/platform-browser": "21.1.0",
	"@angular/platform-browser-dynamic": "21.1.0",
	"@angular/router": "21.1.0",
	"@apollo/client": "4.1.2",
	"@mnd/external-web-view": "file:../app-plugins/dist/packages/external-web-view/mnd-external-web-view-2.0.2.tgz",
	"@mnd/sqlcipher": "file:../app-plugins/dist/packages/sqlcipher/mnd-sqlcipher-1.0.0.tgz",
	"@nativescript/angular": "21.0.0",
	"@nativescript/core": "~9.0.0",
	"@nativescript/iqkeyboardmanager": "2.1.2",
	"@nativescript/localize": "5.2.0",
	"@nativescript/mlkit-barcode-scanning": "file:../app-plugins-customized/mlkit/dist/packages/mlkit-barcode-scanning/nativescript-mlkit-barcode-scanning-3.0.2.tgz",
	"@nativescript/mlkit-core": "file:../app-plugins-customized/mlkit/dist/packages/mlkit-core/nativescript-mlkit-core-3.0.3.tgz",
	"@nativescript/mlkit-custom-object-detection": "file:../app-plugins-customized/mlkit/dist/packages/mlkit-custom-object-detection/nativescript-mlkit-custom-object-detection-3.0.2.tgz",
	"@nativescript/mlkit-object-detection": "file:../app-plugins-customized/mlkit/dist/packages/mlkit-object-detection/nativescript-mlkit-object-detection-3.0.2.tgz",
	"@nativescript/secure-storage": "4.0.1",
	"@nativescript/theme": "3.1.0",
	"@nativescript/ui-charts": "0.2.4",
	"apollo-angular": "13.0.0",
	"apollo3-cache-persist": "0.15.0",
	"d3-ease": "3.0.1",
	"graphql": "16.12.0",
	"graphql-tag": "2.12.6",
	"intl": "1.2.5",
	"moment": "2.30.1",
	"nativescript-health-data": "file:../app-plugins-customized/nativescript-health-data/publish/package/nativescript-health-data-3.0.0.tgz",
	"nativescript-oauth2-ext": "file:../app-plugins-customized/nativescript-oauth2-ext/publish/package/nativescript-oauth2-ext-3.0.5.tgz",
	"nativescript-ui-calendar": "15.2.3",
	"nativescript-ui-gauge": "15.2.3",
	"rxjs": "7.8.2",
	"util": "0.12.5",
	"url": "0.11.4",
	"uuidjs": "5.1.0"
},
"devDependencies": {
	"@angular-devkit/build-angular": "21.1.0",
	"@angular/compiler-cli": "21.1.0",
	"@graphql-codegen/cli": "6.1.1",
	"@graphql-codegen/fragment-matcher": "6.0.0",
	"@graphql-codegen/introspection": "5.0.0",
	"@graphql-codegen/typescript": "5.0.7",
	"@graphql-codegen/typescript-apollo-angular": "4.0.1",
	"@graphql-codegen/typescript-operations": "5.0.7",
	"@nativescript/android": "~9.0.0",
	"@nativescript/ios": "~9.0.0",
	"@nativescript/types": "~9.0.0",
	"@nativescript/webpack": "5.0.24",
	"@ngtools/webpack": "21.1.0",
	"@types/d3-ease": "3.0.2",
	"@types/intl": "1.2.2",
	"@types/lodash": "4.17.23",
	"@types/node": "25.0.9",
	"keycloak-request-token": "0.1.0",
	"patch-package": "^8.0.1",
	"rimraf": "6.1.2",
	"sass": "1.97.2",
	"ts-node": "10.9.2",
	"typescript": "5.9.3"
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the legacy router/router-extensions entry point referenced by the old imports and inspect how its mjs output exposes BackNavigationOptions, ExtendedNavigationBehaviorOptions, and ExtendedNavigationExtras. Done means those three types can be imported from the corresponding NS9 package path with Angular 21.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
frontend, mobile-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.