NativeScript / NativeScript/NativeScript
Observable 'on' and 'off' should return 'this'
Open
Nobody has claimed this yet.
feature
- Dominant language
- TypeScript
- Stars
- 25.7k
- Forks
- 1.7k
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 35
Description
Right now on, once and off methods return nothing
To go with Node events implementation and for easy dev and reading it would be good for those methods to return this.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Observable implementation of the on, once, and off methods and review any nearby event-method tests. Compare their behavior with Node's events API, then confirm the methods support chaining by returning the Observable instance and that the relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100