NativeScript / NativeScript/NativeScript

Margins on Page affects UI and breaks it on iOS

Open
#6,318 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

os: ios
Dominant language
TypeScript
Stars
25.7k
Forks
1.7k
Avg merge
1d 5h
Merged PRs (30d)
35

Description

Which platform(s) does your issue occur on?

iOS/Android/Both

Please provide the following version numbers that your issue occurs with:
  • CLI: 4.2.0
  • Cross-platform modules: 4.2.0
  • Runtime(s): 4.2.0
Please tell us how to recreate the issue in as much detail as possible.

Since {N} 4.0 setting margins, padding and size to a Page results in undefined/different behavior on both platforms. The reason is that on iOS we let the system lay out pages and these properties are ignored. However, they still take part in measure and affect the nested UI.

Proposed Solution: I think the correct behavior is to ignore these properties on the Page component and warn the user they will not take effect.

Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.

Can be reproduced with this playground:
https://play.nativescript.org/?template=play-tsc&id=l4geyI&v=3

The code that is important is:

Page {
    margin: 100;
}

ScrollView {
    margin: 10;
}

On Android it looks correct-ish. On iOS the Page margin is applied on the ScrollView and the ScrollView margin is lost.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked NativeScript TypeScript playground and reproduce the Page and ScrollView margin behavior on iOS and Android using the reported 4.2.0 versions. Trace how Page margins, padding, and size participate in measurement, then verify that these properties no longer affect layout and that users receive a warning when they are set.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, ios, typescript
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.