NatLabRockies / NatLabRockies/rdtools
Consider a "partial" availability analysis for datasets without all the necessary inputs
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 189
- Forks
- 82
- PR merge metrics
- No merged PRs in 30d
Description
Is your feature request related to a problem? Please describe.
The AvailabilityAnalysis class added in #131 requires four inputs: system power, subsystem power, system cumulative energy, and system expected power. The AvailabilityAnalysis class implements two separate analysis strategies, each of which needs only a subset of the three measured fields, but there is no way to only run one of the strategies for datasets that don't have all the fields.
Describe the solution you'd like
Some way to provide the class with only a subset of the inputs and run whichever strategy uses only those inputs. E.g. if a system doesn't have cumulative energy data, then run whatever analysis can be done without it instead of failing immediately.
Describe alternatives you've considered
None
Additional context
The notebook currently shows one way of "getting around" this requirement, but it's sort of hacky and is only half of the desired solution -- it only gives results for loss_system, but the other way round (only giving results for loss_subsystem) isn't possible.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the AvailabilityAnalysis class introduced in #131 and the system_availability_example notebook's “Other use-cases” section. Trace which inputs each analysis strategy requires and how missing fields currently cause failure. Done means datasets with either supported subset can run the applicable strategy and produce the corresponding loss result without the notebook workaround.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100