priorityClasses.create / enabled flags are no-ops (sprig default treats false as empty)

Summary

The priorityClasses.create and priorityClasses.enabled toggles cannot disable behavior. Templates use:

• openstudio-server/templates/priority-class/priority_high.yaml:2 and priority_low.yaml:2

{{- if (default true (get $priorityClasses "create")) -}}

• openstudio-server/templates/web/web-deploy.yaml:35, web-background/web-background-deploy.yaml:31, redis/redis-deploy.yaml:46

{{- if (default true (get $priorityClasses "enabled")) }}

Sprig's default treats false as "empty", so --set priorityClasses.create=false still renders both PriorityClass objects, and priorityClasses.enabled=false still attaches priorityClassName to pods.

Reproduce

helm template test ./openstudio-server --namespace openstudio-server \
  --set global.provider.name=aws --set secrets.create=false \
  --set secrets.validateExistingSecret=false --set priorityClasses.create=false \
  | grep -c 'kind: PriorityClass'   # => 2 (expected 0)

Impact

• Priority classes cannot be opted out via values; they are always created (when not present in the cluster) and always attached.
• The lookup guard in the priority-class templates means an existing cluster is safe, but fresh clusters in other environments cannot disable this feature.

Suggested fix

Gate on key presence, e.g.:

{{- if not (hasKey $priorityClasses "create") | default true }} ... {{- end }}

or restructure to {{- $create := true }}{{- if hasKey $priorityClasses "create" }}{{ $create = get $priorityClasses "create" }}{{ end }}.

Start with the priority-class templates at openstudio-server/templates/priority-class/priority_high.yaml and priority_low.yaml, then inspect the enabled guards in web/web-deploy.yaml, web-background/web-background-deploy.yaml, and redis/redis-deploy.yaml. Render the chart with priorityClasses.create=false and priorityClasses.enabled=false, and verify that no PriorityClass objects are rendered and pods receive no priorityClassName.