NatLabRockies / NatLabRockies/openstudio-server-helm

Helm: web init waitForDb settings defined in values are not used

Open Beginner friendly
#93 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go Template
Stars
12
Forks
24
PR merge metrics
No merged PRs in 30d

Description

Summary

values.yaml and values.schema.json define web.initContainer knobs (image, waitForDb.maxAttempts, waitForDb.retryDelaySeconds), but templates/web/web-deploy.yaml currently hardcodes the init container behavior.

Current behavior

  • Init container image is hardcoded to alpine
  • DB wait loop is hardcoded to seq 1 300 and sleep 3
  • value knobs are ignored at render time

Expected behavior

  • Template should read:
    • web.initContainer.image (with sane default)
    • web.initContainer.waitForDb.maxAttempts
    • web.initContainer.waitForDb.retryDelaySeconds

Why this matters

This is a configuration drift/footgun: operators may tune these values in overlays and assume they are active, but runtime behavior remains fixed.

Suggested fix

Wire the web init container command/image to the existing values fields and preserve current defaults (300 attempts, 3s delay) when unset.

Acceptance criteria

  1. helm template output changes when those values are overridden.
  2. Defaults match current behavior if not overridden.
  3. scripts/install-dry-run.sh checks pass.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with values.yaml, values.schema.json, and templates/web/web-deploy.yaml to trace the existing web init container settings and command. Render the chart with helm template using default and overridden values, then run scripts/install-dry-run.sh. Done means overrides affect the image, maximum attempts, and retry delay while defaults remain 300 attempts and 3 seconds.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm
Domain
devops, infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.