NatLabRockies / NatLabRockies/openstudio-server-helm

Helm: worker strategy maxUnavailable value is ignored by template

Open Beginner friendly
#92 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go Template
Stars
12
Forks
24
PR merge metrics
No merged PRs in 30d

Description

Summary

openstudio-server/templates/worker/worker-deploy.yaml hardcodes maxUnavailable: 1 even though values.yaml exposes worker.strategy.maxUnavailable and docs/comments describe tuning it.

Current behavior

  • Template line uses a literal: maxUnavailable: 1
  • worker.strategy.maxUnavailable from values is not wired into the rendered Deployment

Expected behavior

  • maxUnavailable should be sourced from values, similar to maxSurge
  • If unset, use a safe default (current behavior can remain the default)

Why this matters

Operators cannot apply intended rollout controls from values files, which can cause unexpected rollout speed/disruption in large worker fleets.

Suggested fix

In templates/worker/worker-deploy.yaml, replace hardcoded maxUnavailable: 1 with value lookup from worker.strategy.maxUnavailable and fallback default.

Acceptance criteria

  1. helm template reflects worker.strategy.maxUnavailable when set in values.
  2. Existing default behavior remains when not set.
  3. scripts/install-dry-run.sh checks pass.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with templates/worker/worker-deploy.yaml and compare its maxUnavailable handling with maxSurge and the worker.strategy settings in values.yaml. Run helm template with worker.strategy.maxUnavailable set and unset, then run scripts/install-dry-run.sh. Done means the configured value renders when set and the existing default remains otherwise.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
84/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.