NatLabRockies / NatLabRockies/SAM
Flow Battery Sizing doesn't limit power when "both" is selected
Open
@brtietz is already working on this.
Since Jun 18, 2026.
bug
- Dominant language
- C++
- Stars
- 486
- Forks
- 219
- Avg merge
- 10h 10m
- Merged PRs (30d)
- 2
Description
The flow battery allows for limiting cells based on power, current, or both.
For this case, limiting power results in 6,000,015 cells:
Limiting current results in 4,285,715
Limiting both should result in the larger number, but results in the current limited number due to internal logic:
This means that the maximum output of the battery is 50.96 MW, when 60 MW was specified.
This will be updated as a part of the transition to SSC equations for battery sizing.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.