NatLabRockies / NatLabRockies/SAM
Battery replacement requires cycle degradation
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 486
- Forks
- 219
- Avg merge
- 10h 10m
- Merged PRs (30d)
- 2
Description
Describe the bug
The battery life model calculates both cycle and calendar degradation, however battery replacements appear to only be triggered when there is cycle degradation.
The replacement code is triggered, but then something overwrites the replacement and it ends up re-running every timestep.
lifetime_replacements_test.zip
See https://sam.nrel.gov/forum/forum-general/5101-battery-degradation-and-lifetime.html#14386.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lifetime_replacements_test.zip and the battery life model's replacement path; reproduce the repeated replacement behavior across timesteps and compare cycle versus calendar degradation. Done means replacements are not overwritten or retriggered every timestep, and the attached lifetime scenario passes for calendar as well as cycle degradation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100