NatLabRockies / NatLabRockies/SAM
Shading loss misattributed to module difference from STC
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 486
- Forks
- 219
- Avg merge
- 10h 10m
- Merged PRs (30d)
- 2
Description
Describe the bug
Creating a scene with the 3D shade calculator reduces DC energy by 12.8%, but only 0.6% of this is attributed to shading in the loss table, the rest is attributed to module difference from STC.
To Reproduce
Steps to reproduce the behavior:
- Download the attached SAM file
- Run both cases
- Look at the loss diagram
- See error
Expected behavior
I would expect shading losses to be attributed to shading
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by downloading shading_bug_sample_case.zip, running both cases, and comparing the loss diagram to confirm how the 12.8% DC reduction is categorized. Trace the 3D shade calculator's loss attribution and determine why most loss is reported as module difference from STC; done means the loss table attributes the reduction to shading.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100