NatLabRockies / NatLabRockies/SAM

PVGIS converter macro uses out of date fields

Open
#2,104 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
486
Forks
219
Avg merge
10h 10m
Merged PRs (30d)
2

Description

Describe the bug

When downloading a file from https://re.jrc.ec.europa.eu/pvg_tools/en/tools.html#TMY, the conversion to SAM CSV errors out on line 948, which deals with timestep conversions.

It looks like the converter code expects 01/01/2013 00:00:00
Whereas the actual file is:
20080101:0000

Workaround is to download an epw formatted file instead.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the PVGIS-to-SAM CSV converter code at line 948, where timestep conversions are reported to fail. Compare the expected 01/01/2013 00:00:00 value with the downloaded 20080101:0000 format. Done means the PVGIS file converts to SAM CSV without the line 948 error.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.