NatLabRockies / NatLabRockies/SAM
Subhourly Clipping Correction Call-out on Loss Tree for Walker Method
Open
@mjprilliman is already working on this.
Since Sep 27, 2025.
- Dominant language
- C++
- Stars
- 486
- Forks
- 219
- Avg merge
- 10h 10m
- Merged PRs (30d)
- 2
Description
NREL SAM 2025.4.16: If you run the Allen subhourly clipping model in NREL SAM, there will be an added loss on the loss tree "subhourly clipping correction". However, if you run the Walker subhourly clipping model, there is no such line item on the loss tree. I think it would be helpful to have some call-out on the loss tree for the Walker model, but I'm also interested to understand if there's a reason why the two loss trees are not similar in this way. Thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.