NatLabRockies / NatLabRockies/SAM
Improve variable labels for PV outputs
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 486
- Forks
- 219
- Avg merge
- 10h 10m
- Merged PRs (30d)
- 2
Description
We recently revised labels of time series irradiance outputs for the pvsamv to make the progression from available irradiance to irradiance incident on the PV cell easier to follow: https://github.com/NREL/ssc/pull/1153
This request is for some additional improvements:
-
Monthly "POA front-side irradiance total" should be "POA front-side irradiance total after reflection and soiling (IAM)" to be consistent with time series output labels.
-
"(IAM)" in the labels is a little abiguous. Something like "IAM losses" would be clearer.
-
For mono-facial modules, "POA front-side total..." and "POA irradiance total..." are the same and appear to be duplicate variables. Consider only reporting "front" and "rear" outputs when bifacial option is enabled.
-
Consider adding calculated "Module efficiency" to loss diagram:
See attached slides for screenshots:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the pvsamv monthly and time-series output labels and the loss diagram described in the issue, using the attached feedback slides for the intended wording. Done means the labels distinguish IAM losses clearly, duplicate mono-facial outputs are handled when appropriate, and the module-efficiency request has a decided outcome.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 40/100