NatLabRockies / NatLabRockies/SAM

Support Inf and NaN for numeric inputs and update defaults

Open
#2,050 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
486
Forks
219
Avg merge
10h 10m
Merged PRs (30d)
2

Description

Related to #1856, which adds support for NaN and Inf in the DataMatrix widgets for electricity rate inputs.

Currently, it is not possible to type "Inf" for numeric inputs with default value of 1e38 like incentives.

  • Enable NaN and Inf for numeric inputs.
  • Update all defaults with value of 1e+38 to Inf

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the numeric-input handling for DataMatrix widgets and searching for defaults set to 1e+38. Confirm where numeric values are parsed and where the defaults are defined; the work is done when numeric inputs accept NaN and Inf and all identified 1e+38 defaults use Inf.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.