NatLabRockies / NatLabRockies/SAM
Spatial albedo table defaults?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 486
- Forks
- 219
- Avg merge
- 10h 10m
- Merged PRs (30d)
- 2
Description
The most logical thing for the spatial albedo table defaults would be to have all of it be 0, but instead all the rows are 5. I don't think this is a showstopper, so let's update it for patch 1 (or decide that the default of 5 is on purpose).
Found in Detailed PV/No Financials default case. Same in 2023.12.17 release.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Detailed PV/No Financials default case and inspect how the spatial albedo table rows receive their defaults. Compare the behavior with the 2023.12.17 release and determine whether the value 5 is intentional; done means the intended default is documented or the table consistently uses the corrected value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100