NatLabRockies / NatLabRockies/SAM
Improve consistency in PV-Battery availability losses
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 486
- Forks
- 219
- Avg merge
- 10h 10m
- Merged PRs (30d)
- 2
Description
-
Thank you for adding the Battery availability loss output.
There is some inconsistency now:
- Total AC availability is reported as a single value in %
- Total DC availability is reported as a single value in %
- Total battery availability is not reported.
- Time series AC availability loss is reported in kW
- Time series DC availability loss is not reported
- Time series battery availability loss is reported in %
This is probably a separate issue to handle the output consistently across all performance models.
Originally posted by @cpaulgilman in https://github.com/NREL/SAM/issues/1902#issuecomment-2475078932
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Start by locating the performance-model outputs for AC, DC, and battery availability, then determine the intended units and reporting behavior across models; done means the totals and time-series losses are reported consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100