NatLabRockies / NatLabRockies/SAM
Combine Cases uses the wrong capacity number for PV
Open
@brtietz is already working on this.
Since May 22, 2024.
bug
- Dominant language
- C++
- Stars
- 486
- Forks
- 219
- Avg merge
- 10h 10m
- Merged PRs (30d)
- 2
Description
Describe the bug
When adding a PV case to the generic system's "combine cases" function, the function adds a dc system capacity to an AC system capacity number.
To Reproduce
Steps to reproduce the behavior:
- Open multiple PV cases
- Open a generic system case and choose the combine cases option
- The (AC) combined capacity will be the sum of the DC capacity of the systems
Attached file demonstrates the issue:
combine_cases_ac_vs_dc_issue.zip
Expected behavior
Combine cases should use AC capacity numbers for all incoming systems.
Operating System and Version
- Version 2023.12.17, maybe others.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.