NatLabRockies / NatLabRockies/SAM
NMC-life model issues in extreme cold
@dguittet is already working on this.
Since May 22, 2024.
- Dominant language
- C++
- Stars
- 486
- Forks
- 219
- Avg merge
- 10h 10m
- Merged PRs (30d)
- 2
Description
Describe the bug
To test how the battery model performs in extreme cold, I put in weather file temperature data for Fairbanks, AK into the "enter the time series temperature" slot. This raised a few issues:
- Since the NMC-life model handles temperature as well, 5+ battery replacements are triggered each year
- The battery capacity percent for temperature output is stuck at 100%
To Reproduce
Steps to reproduce the behavior:
- Download the zip and add the weather file to your library
- Run extreme_cold_nmc_life case
extreme_cold_tests.zip
Expected behavior
For (1) - the battery degradation code might need to look at a different value
For (2) - we should either tie the temperature % code to a different value or remove it from the outputs. Additionally if the inputs on in the chart the battery thermal page are unused for a given life model, they should be disabled in the UI.
Screenshots

Operating System and Version
- Version 2022.11.21. I expect this is a problem in 2021.12.02 as well
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.