NatLabRockies / NatLabRockies/SAM

NMC-life model issues in extreme cold

Open
#1,291 3 comments 0 reactions 1 assignee View on GitHub

@dguittet is already working on this.

Since May 22, 2024.

battery bug
Dominant language
C++
Stars
486
Forks
219
Avg merge
10h 10m
Merged PRs (30d)
2

Description

Describe the bug

To test how the battery model performs in extreme cold, I put in weather file temperature data for Fairbanks, AK into the "enter the time series temperature" slot. This raised a few issues:

  1. Since the NMC-life model handles temperature as well, 5+ battery replacements are triggered each year
  2. The battery capacity percent for temperature output is stuck at 100%
To Reproduce

Steps to reproduce the behavior:

  1. Download the zip and add the weather file to your library
  2. Run extreme_cold_nmc_life case
    extreme_cold_tests.zip
Expected behavior

For (1) - the battery degradation code might need to look at a different value

For (2) - we should either tie the temperature % code to a different value or remove it from the outputs. Additionally if the inputs on in the chart the battery thermal page are unused for a given life model, they should be disabled in the UI.

Screenshots

image

Operating System and Version
  • Version 2022.11.21. I expect this is a problem in 2021.12.02 as well

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.