NatLabRockies / NatLabRockies/REopt_API
loads_kw_is_net default value is True for builtin load profiles
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 125
- Forks
- 68
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 1
Description
Issue:
The loads_kw_is_net input value defaults to True because it is assumed that most users that upload meter data for their load profile will have data that is net of PV production (gross load - PV). However, because loads_kw_is_net=True by default, when a user does not upload their load profile and uses a builtin profile, as well as specifies non-zero existing_kw for PV, the gross load gets calculated as the builtin profile plus the existing PV production, thus inflating the load profile beyond the DOE reference values.
Proposed solution:
When using a builtin profile have the API change the loads_kw_is_net value to False.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace how the API handles loads_kw_is_net for builtin load profiles and how existing_kw for PV affects the resulting gross load. Confirm the behavior against the DOE reference values, then update the builtin-profile path so its default handling does not inflate the load profile and verify the affected API behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100