NatLabRockies / NatLabRockies/REopt_API

Remove duplicate validation efforts that are handled in REopt.jl

Open
#387 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
125
Forks
68
Avg merge
1d 21h
Merged PRs (30d)
1

Description

Note: for support questions and enhancement suggestions please use the REopt Forum (under development). This repository's issues are reserved for feature requests and bug reports.

  • I'm submitting a ...

    • bug report
    • feature request
    • support request => Please do not submit support request here, see note at the top of this template.
  • What is the current behavior?
    Duplicate validations take place from REopt.jl and the API. With the new message passing and logger recently added to REopt.jl, this is unneccessary.

This issue was created in response to a comment by @Bill-Becker in https://github.com/NREL/REopt_API/pull/329

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the duplicate validation flow in the REopt_API repository and the related discussion in pull request #329. Trace how REopt.jl's message passing and logger are used by the API. Done means removing redundant validation while preserving the remaining validation behavior and messages.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia, python
Domain
api, backend, backend-api-design
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.