NatLabRockies / NatLabRockies/REopt_API
generator_only_runs_during_grid_outage=True forces size_kw=0
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 125
- Forks
- 68
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 1
Description
-
I'm submitting a ...
- bug report
- feature request
- support request => Please do not submit support request here, see note at the top of this template.
-
Do you want to request a feature or report a bug?
bug -
What is the current behavior?
If generator_only_runs_during_grid_outage=True, then the generator size output is zero, even if non-zero existing generator or minimum size is given. In addition to the size being incorrect, this will affect costs (O&M and, if gen not existing, capX) and cause issues in postprocessing (e.g. outage simulator script). -
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
- specify a non-zero existing_kw or min_kw for Generator
- set generator_only_runs_during_grid_outage=True
- don’t put in an outage (outage start and end are null)
-
What is the expected behavior?
If generator_only_runs_during_grid_outage=True, then generator size_kw output should be existing_kw+min_kw -
What is the motivation / use case for changing the behavior?
incorrect output -
Please tell us about your environment:
- REopt API Version: on develop branch
- Operating System: macOS Catalina
- Python version: 3.6.13
- Julia version: 1.5
-
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the case with a non-zero Generator existing_kw or min_kw, generator_only_runs_during_grid_outage=True, and null outage start and end. Trace the generator sizing logic and verify that size_kw becomes existing_kw+min_kw, while costs and postprocessing remain consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia, python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100