NatLabRockies / NatLabRockies/OpenStudio

Infiltration parameter does not seem to be used in ISO UserModel

Open
#861 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component - ISO Model severity - Normal Bug
Dominant language
C++
Stars
646
Forks
237
Avg merge
3d 11h
Merged PRs (30d)
10

Description

The parameter that is used seems to be buildingAirLeakage, seems like infiltration should be removed?

https://github.com/NREL/OpenStudio/blob/fb79c6ea728b2a71b32fa5a27ecf1830f939d7b1/openstudiocore/src/isomodel/UserModel.cpp#L101

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at openstudiocore/src/isomodel/UserModel.cpp around line 101 and trace references to the infiltration and buildingAirLeakage parameters. Confirm which parameter is used in the ISO UserModel and determine whether the unused parameter should be removed; completion requires the model behavior and relevant tests to reflect that decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.