NatLabRockies / NatLabRockies/OpenStudio
Revamp full-buil.yml
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
Description
full-build.yml has a lot of weirdness in there. Everytime I start looking I find something extremely strange.
Also, we should have a full green for the workflow, which isn't true right now.
Current Behavior
Why does windows add Miktex?!
Why does Windows use NSIS generator and not IFW (QtIFW) like we've done for ages?
Why does it patch the python/module/openstudio.py instead of making the change in git directly?
Expected Behavior
Should be clean and sensible.
Steps to reproduce
Possible Solution
No response
Operating System affected
No response
Environment
all
Version of OpenStudio
3.11.0
Context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/workflows/full-build.yml, especially the Windows section around line 1322, and inspect the existing full-build workflow from setup through packaging. Compare the MikTeX, NSIS/QtIFW, and Python-module patching steps, then run the full workflow. Done means the workflow is cleaned up and completes fully green on all supported environments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, python
- Domain
- build-system, ci-cd
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100