NatLabRockies / NatLabRockies/OpenStudio
Allow `Sizing:System` objects to be removed from model
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
General Summary
Allow Sizing:System objects to be removed from the model. It is confusing to have these objects in the model when they are not used.
Detailed Description
Sizing:System objects are not required by EnergyPlus, and we do not use them for our residential simulations. However, OpenStudio does not allow these objects to be removed. If you try air_loop.sizingSystem.remove, you hit this error here.
Likewise, it'd be nice if the Sizing:Parameters object could be removed. (It's also strange than the default heating/cooling sizing factors are 1.25/1.1 and differ from the E+ IDD defaults of 1.0/1.0. If the defaults were the same, OS would not have to create/FT this object unless a user wanted to change from the defaults.)
Possible Implementation
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/model/AirLoopHVAC.cpp around line 1207, where removing a Sizing:System object currently fails. Trace the corresponding handling for Sizing:Parameters and determine how removal should affect the model. Done means unused Sizing:System and Sizing:Parameters objects can be removed without triggering the current error or leaving them in the model.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100