NatLabRockies / NatLabRockies/OpenStudio
Follow up for AFNCoilNames after E+ determination
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
Issue overview
-
Related to #5479
-
Follow up after this https://github.com/NREL/EnergyPlus/issues/11274#issuecomment-3430904239 is addressed
Current Behavior
Summary of what I think is happening
These objects are missing the \reference AFNCoilNames: (already part of Solver.cpp)
field_keys - afn_coils
{'Coil:Heating:Electric:MultiStage', 'Coil:Heating:Gas:MultiStage'}
AirflowNetwork:Distribution:Component:Coil Coil Object Type is potentially missing this entry: (Object is not part of Solver.cpp though)
afn_coils - field_keys
{'Coil:Cooling:DX:SingleSpeed:ThermalStorage'}
Expected Behavior
Steps to Reproduce
Possible Solution
Details
Environment
Some additional details about your environment for this issue (if relevant):
- Platform (Operating system, version):
- Version of OpenStudio (if using an intermediate build, include SHA):
Context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read src/EnergyPlus/AirflowNetwork/src/Solver.cpp at lines 10653-10668, then review related issue #5479 and the linked EnergyPlus discussion. Verify whether the listed multi-stage heating coils and thermal-storage cooling coil need AFNCoilNames references, and confirm the relevant definitions are consistent when the follow-up work is complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100