NatLabRockies / NatLabRockies/OpenStudio
ThreeJS annoying error messages when using OS:Construction:FfactorGroundFloor
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
Issue overview
Current Behavior
using view_data, which will use ThreeJSForwardTranslator
Expected Behavior
Steps to Reproduce
- Create a Model with Construction FfactorGroundFloor
- modelToThreeJS
- Enjoy the warnings
Possible Solution
Missing here: https://github.com/NREL/OpenStudio/blob/37db4c45de2f6bd8a2c7f618f7aecf5ee1a169c2/src/utilities/geometry/ThreeJS.cpp#L48-L70
Details
Environment
Some additional details about your environment for this issue (if relevant):
- Platform (Operating system, version): All
- Version of OpenStudio (if using an intermediate build, include SHA): 3.10.0
Context
Was reported by @James-py here https://github.com/openstudiocoalition/OpenStudioApplication/issues/819#issuecomment-3046029149
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/utilities/geometry/ThreeJS.cpp, especially lines 48-70 linked in the issue, and reproduce the warnings using a model with Construction FfactorGroundFloor followed by modelToThreeJS. Compare the handling there with the reported warnings; done means this construction no longer produces the unwanted ThreeJS error messages.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, three.js
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100