NatLabRockies / NatLabRockies/OpenStudio
SizingSystem::autosizedDesignOutdoorAirFlowRate is grabbing the wrong quantity
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
Issue overview
Emphasis mine:
Field: Design Outdoor Air Flow Rate
The design outdoor air flow rate in cubic meters per second. Generally this should be the minimum outdoor air flow. It is used for both heating and cooling design calculations. The assumption for cooling is that any outdoor air economizer will be closed. If Autosize is input the outdoor air flow rate will be taken from the sum of the zone outdoor air flow rates or calculated based on the System Outdoor Air Method selection (field below).
Current Behavior
Expected Behavior
I'm pretty sure it should instead grab the controller OA autosizedMinimumOutdoorAirFlowRate and not the autosizedMaximumOutdoorAirFlowRate
Steps to Reproduce
Given a VAV_Reheat (Sys7) serving multiple (54) zones, the sum of the DSOA flow rates is 113 m3/s.
After running a sizing run:
[23] pry(#<ACM179dASHRAE9012007>)> controller_oa.autosizedMinimumOutdoorAirFlowRate.get
=> 113.14067242054135
[24] pry(#<ACM179dASHRAE9012007>)> controller_oa.autosizedMaximumOutdoorAirFlowRate.get
=> 363.09677246176363
a.airLoopHVACOutdoorAirSystem.get.getControllerOutdoorAir.autosizedMaximumOutdoorAirFlowRate.get == a.sizingSystem.autosizedDesignOutdoorAirFlowRate.get
=> true
I guess AirDuctType::Cooling and AirDuctType::Heating is for the Dual Duct AirLoopHVAC, and mine would be a Main.
controller_oa.autosizedMinimumOutdoorAirFlowRate.get / controller_oa.autosizedMaximumOutdoorAirFlowRate.get
=> 0.31159922368204407
The Constant Minimum Air Flow Fraction of the AirTerminalSingleDuctVAVReheats is around 0.3
IIF I'm following correctly, the Maximum Outdoor Air Flow Rate is equal to maximum Flow Rate (which includes flow for OA and conditioning)?
Possible Solution
Details
Environment
Some additional details about your environment for this issue (if relevant):
- Platform (Operating system, version): all
- Version of OpenStudio (if using an intermediate build, include SHA): 3.10.0
Context
179D
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/model/SizingSystem.cpp around lines 698-715 and compare the sizing system's autosized design outdoor air flow rate with the controller outdoor air getters described in the issue. Run a sizing case like the VAV_Reheat Sys7 reproduction and trace the referenced EnergyPlus outdoor-air calculations. Done means the sizing system uses the intended minimum outdoor air flow rate rather than the maximum.
Written by the indexing model from the issue text.
Assessment
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100