NatLabRockies / NatLabRockies/OpenStudio

ScheduleFile has non implemented methods such as TimeSeries

Open
#5,247 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component - Model
Dominant language
C++
Stars
646
Forks
237
Avg merge
3d 11h
Merged PRs (30d)
10

Description

Issue overview

A bunch of public methods actually have zero implementation, and no warning whatsoever. Been like this for 6 years

Current Behavior

https://github.com/NREL/OpenStudio/blob/ba1b94b6542c1f1d4cdcdb775886852b9a82bc4f/src/model/ScheduleFile.cpp#L289-L306

Expected Behavior

They should be removed or implemented, given that they are public

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): all
  • Version of OpenStudio (if using an intermediate build, include SHA): 3.8.0, develop
Context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/model/ScheduleFile.cpp lines 289-306, especially the public methods such as TimeSeries, and inspect their declarations and related ScheduleFile usage. Determine for each method whether it should be implemented or removed, then verify that no public method remains silently unimplemented.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend-api-design
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.