NatLabRockies / NatLabRockies/OpenStudio

C++ CLI: OutputAdapter is not implemented while it was present in the workflow-gem

Open
#5,107 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component - CLI component - Workflow severity - Normal Bug
Dominant language
C++
Stars
646
Forks
237
Avg merge
3d 11h
Merged PRs (30d)
10

Description

Enhancement Request

Seems like the feature was actually used as reported by @chriswmackey on https://github.com/NREL/OpenStudio/issues/5069#issuecomment-1986642054

This is also related to #5073 since socket was one of the default adapters provided by openstudio-workflow-gem

Detailed Description

cf https://github.com/NREL/OpenStudio-workflow-gem/blob/696306b5b24cd597edc6ab04faa1e618f99db190/lib/openstudio/workflow/adapters/output_adapter.rb#L8-L11

Possible Implementation

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the referenced workflow-gem file, lib/openstudio/workflow/adapters/output_adapter.rb, and trace where adapters enter the C++ CLI. Compare the existing CLI adapters with the gem behavior; done means the OutputAdapter is available in the CLI and matches the referenced workflow behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, ruby
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.