NatLabRockies / NatLabRockies/OpenStudio
WorkflowJSON constantly calling setMeasureTypes (in the Ctor, in clone, in save, etc)
@jmarrec is already working on this.
Since Jan 25, 2024.
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
ValidateXML getting called a lot.
This is from slack convo from Julien:
WorkflowJSON.cpp
(https://github.com/NREL/OpenStudio/blob/1ce97f5651ff868500e4168aaa8e0a441559edce/src/utilities/filetypes/WorkflowJSON.cpp)
for (const auto& step : m_steps) {
if (step.optionalCastMeasureStep()) {
boost::optionalBCLMeasure bclMeasure = getBCLMeasure(step.castMeasureStep());
https://github.com/[NREL/OpenStudio](https://github.com/NREL/OpenStudio)|NREL/OpenStudioNREL/OpenStudio | Added by GitHub
10:18
that in turns loads the BCLMeasure, which validates the XML...
I do not get this to the out.osw “stdout” key with 3.7.0 on unix at least, but it’s in the run.log
that constant loading the BCLMeasure has been here for 8 years. What changed is that there used to be no XMLValidator happening.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.