NatLabRockies / NatLabRockies/OpenStudio

Force ascending order of independant variables in Table:IndendependentVariable

Open
#4,976 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component - IDF Translation component - Model severity - Minor Bug
Dominant language
C++
Stars
646
Forks
237
Avg merge
3d 11h
Merged PRs (30d)
10

Description

Issue overview

I had noted it here as a question: https://github.com/NREL/OpenStudio/pull/4652#discussion_r959732497

Current Behavior

We get a bunch of errors on the SDD ReverseTranslator tests of openstudio-resources due to this

   ** Severe  ** Table:IndependentVariable \"{172A710A-926C-44EC-9AC3-1E694B8332A0}\": axis is not sorted.",
   **  Fatal  ** Btwxt: Errors discovered, program terminates.

Expected Behavior

Worked as 3.4.0, stopped working at 3.5.0 when we moved from Table:MultiVariableLookup

https://github.com/NREL/OpenStudio-resources/blob/46a3246cd12026af71fc7db11d990697bf002b9b/test/010112_SchSml_PSZ16.xml_3.4.0_out.osw#L2

https://github.com/NREL/OpenStudio-resources/blob/46a3246cd12026af71fc7db11d990697bf002b9b/test/010112_SchSml_PSZ16.xml_3.5.0_out.osw#L1-L7

Steps to Reproduce

make a non sorted one. try to run in E+.

Possible Solution

Force ascending order. Determine if should be done in Model or at ForwardTranslation time.

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): all
  • Version of OpenStudio (if using an intermediate build, include SHA): 3.5.0+
Context

Noticed this today when I ran the OpenStudio-resources testing with 3.6.1 official.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Table:IndependentVariable handling involved in the SDD ReverseTranslator tests and compare the 3.4.0 and 3.5.0 resource outputs linked in the issue. Reproduce the unsorted-axis error by running a non-sorted table in EnergyPlus, then determine whether ascending order belongs in the Model or during ForwardTranslation and verify the SDD tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.