NatLabRockies / NatLabRockies/OpenStudio
Remove TableMultiVariableLookup in 3.7.0 (or 3.7.1)
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
Enhancement Request
The object was "deprecated" at 3.5.0. In VT we already translated this to Table:Lookup.
We kept the object in place for backward compat.
Detailed Description
Possible Implementation
In 3.7.0/3.7.1 (3.7.1 if we don't want to complicate VT rules even more), redo the translation to TableLookup - in case someone created a 3.5.1, 3.6.0 or 3.6.1 model with it anyways - and completely remove the object
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the TableMultiVariableLookup-to-Table:Lookup translation and the object definition in the OpenStudio codebase. Check how models from versions 3.5.1 through 3.6.1 are translated, then verify that the object is removed while backward-compatible translation remains correct for the selected 3.7.0 or 3.7.1 target.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100