NatLabRockies / NatLabRockies/OpenStudio

3.5.0: If installing the CLI but not the CPPAPI, we still need to ship libopenstudiolib

Open
#4,727 0 comments 0 reactions 1 assignee View on GitHub

@jmarrec is already working on this.

Since Nov 18, 2022.

component - CLI severity - Minor Bug
Dominant language
C++
Stars
646
Forks
237
Avg merge
3d 11h
Merged PRs (30d)
10

Description

Issue overview

Currently the cpack_ifw stuff is laid out in a way where you can install the CLI but opt out the CPPAPI, and the libopenstudiolib is part of that later, so you end up with a broken CLI.

Reported by @shorowit

Possible Solution

Either make CPPAPI a required component, or make libopenstudiolib part of another component that the CLI will depend on.

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version):
  • Version of OpenStudio (if using an intermediate build, include SHA):
Context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.