NatLabRockies / NatLabRockies/OpenStudio

Multiple shading controls for a single subsurface

Open
#4,602 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

EnergyPlus Issue
Dominant language
C++
Stars
646
Forks
237
Avg merge
3d 11h
Merged PRs (30d)
10

Description

Issue overview

We implemented https://github.com/NREL/OpenStudio/pull/4066 to allow a single subsurface to reference multiple shading control objects. While the API now permits this, it appears that the simulation is ignoring any additional shading controls beyond the first one.

Current Behavior

The "Window Control" table in eplustbl.htm does not contain any rows for "Shading Control 2".

Expected Behavior

The "Shading Control 2" object has subsurfaces applied to it, so we'd expect it to be listed in the "Window Control" table.

Steps to Reproduce

Run shadingcontrol_singlezone.rb from OS-resources: https://github.com/NREL/OpenStudio-resources/blob/develop/model/simulationtests/shadingcontrol_singlezone.rb. Look at eplustbl.htm.

Possible Solution

Maybe some specific property(ies) need to be set on "Shading Control 2", otherwise it gets ignored?

Details

Additional resources:

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version):
  • Version of OpenStudio (if using an intermediate build, include SHA):
Context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run shadingcontrol_singlezone.rb from OS-resources and inspect eplustbl.htm, focusing on the Window Control table and the missing Shading Control 2 rows. Review the related OS-resources test changes and the shading control follow-up PR 4103; done means the second shading control's subsurfaces appear in the table.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.