NatLabRockies / NatLabRockies/OpenStudio
Multiple shading controls for a single subsurface
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
Issue overview
We implemented https://github.com/NREL/OpenStudio/pull/4066 to allow a single subsurface to reference multiple shading control objects. While the API now permits this, it appears that the simulation is ignoring any additional shading controls beyond the first one.
Current Behavior
The "Window Control" table in eplustbl.htm does not contain any rows for "Shading Control 2".
Expected Behavior
The "Shading Control 2" object has subsurfaces applied to it, so we'd expect it to be listed in the "Window Control" table.
Steps to Reproduce
Run shadingcontrol_singlezone.rb from OS-resources: https://github.com/NREL/OpenStudio-resources/blob/develop/model/simulationtests/shadingcontrol_singlezone.rb. Look at eplustbl.htm.
Possible Solution
Maybe some specific property(ies) need to be set on "Shading Control 2", otherwise it gets ignored?
Details
Additional resources:
- New/modified OS-resources tests: https://github.com/NREL/OpenStudio-resources/pull/147
- Shading control follow-up PR: https://github.com/NREL/OpenStudio/pull/4103
- Relevant comment: https://github.com/NREL/OpenStudio/pull/4066#issuecomment-868760359
Environment
Some additional details about your environment for this issue (if relevant):
- Platform (Operating system, version):
- Version of OpenStudio (if using an intermediate build, include SHA):
Context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Run shadingcontrol_singlezone.rb from OS-resources and inspect eplustbl.htm, focusing on the Window Control table and the missing Shading Control 2 rows. Review the related OS-resources test changes and the shading control follow-up PR 4103; done means the second shading control's subsurfaces appear in the table.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100