NatLabRockies / NatLabRockies/OpenStudio

Update LifeCycleCostParameters to allow maximum FEMP study period of 40 years

Open
#4,552 0 comments 2 reactions 1 assignee View on GitHub

@jmarrec is already working on this.

Since Apr 22, 2022.

component - Model Enhancement Request
Dominant language
C++
Stars
646
Forks
237
Avg merge
3d 11h
Merged PRs (30d)
10

Description

Enhancement Request

The 2020 edition of NIST Handbook 135, Life Cycle Costing Manual for the Federal Energy Management Program extends the maximum study period from 25 years to 40 years.
https://nvlpubs.nist.gov/nistpubs/hb/2020/NIST.HB.135-2020.pdf

The limit is hardcoded into OpenStudio here:
https://github.com/NREL/OpenStudio/blob/b8d0e3a845faa3c34fd6263e53e931309101d296/src/model/LifeCycleCostParameters.cpp#L528

and here:
https://github.com/NREL/OpenStudio/blob/b8d0e3a845faa3c34fd6263e53e931309101d296/src/model/LifeCycleCostParameters.cpp#L406

It would be nice if this limit was documented in the OpenStudio IDD, SDK documentation, an error message, etc., since currently the maximum study period is nominally limited by the IDD to 100 years, but is really silently limited based on analysis choice.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.