NatLabRockies / NatLabRockies/OpenStudio
DesignSpecificationOutdoorAir when using Spaces will be wrong in a varierty of places (like Terminal)
Open
@jmarrec is already working on this.
Since Nov 17, 2021.
component - HVAC
component - IDF Translation
severity - Major Bug
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
Issue overview
When you combineSpaces, no problem: the spaces().front() returns the single space, and the dsoa it has is combining too.
When you use E+ spaces, we create a DSOA List in FTThermalZOne here: https://github.com/NREL/OpenStudio/blob/6977f79d05f2d2fef4c3f76a02939c796ac3dbca/src/energyplus/ForwardTranslator/ForwardTranslateThermalZone.cpp#L955-L961
That's what we need to be using on the AirTerminal.
Possible Solution
Details
Environment
Some additional details about your environment for this issue (if relevant):
- Platform (Operating system, version): all
- Version of OpenStudio (if using an intermediate build, include SHA): 3.3.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.