NatLabRockies / NatLabRockies/OpenStudio

Concerning roof geometry from floor js json import

Open
#4,489 1 comment 0 reactions 1 assignee View on GitHub

@tijcolem is already working on this.

Since Nov 5, 2021.

component - Utilities Geometry severity - Minor Bug
Dominant language
C++
Stars
646
Forks
237
Avg merge
3d 11h
Merged PRs (30d)
10

Description

Issue overview

I am using the following code to import this floor js json into OpenStudio

 floorplan = OpenStudio::FloorplanJS::load(floor_js_json_data)
  if floorplan.empty?
    raise "Cannot load floorplan from '#{floorplan_path}'."
  end

  scene = floorplan.get.toThreeScene(true)

  rt = OpenStudio::Model::ThreeJSReverseTranslator.new

  model = rt.modelFromThreeJS(scene)

Concerning roof geometry is produced from the floor js json import

The space seen in the screenshot below:

image

Produces the roof geometry below:

image

Although the floor geometry comes out just fine

image

Please find the floor js json from here:

https://drive.google.com/file/d/13b4EYEykWXPemMIaas-jPsCy7i-GOHid/view?usp=sharing

Environment

OpenStudio 3.2.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.