NatLabRockies / NatLabRockies/OpenStudio
Design minimum zone ventilation efficiency is used in the mechanical ventilation controller
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
Issue overview
After forward translation, the design minimum zone ventilation efficiency is in the sizing zone object and also used in the mechanical ventilation controller. This issue I think both a bug and enhancement request. https://github.com/NREL/OpenStudio/issues/3898 is a related issue.
Current Behavior
The setDesignMinimumZoneVentilationEfficiency method not only sets the design minimum zone ventilation efficiency but uses the same value in the mechanical ventilation controller after translation by using the same DesignSpecification:ZoneAirDistribution for Sizing:Zone and Controller:MechanicalVentilation.
Expected Behavior
Since design is mentioned in the name of the method, it should probably only be applied to the Sizing:Zone object. It is common to use two different DesignSpecification:ZoneAirDistributions in Sizing:Zone and Controller:MechanicalVentilation objects. If I am not mistaken, this cannot currently be done in OpenStudio. It would be nice to perhaps have two different methods, one for design and one for operation.
Details
Translation is done here.
Environment
Some additional details about your environment for this issue (if relevant):
- Platform (Operating system, version): All
- Version of OpenStudio (if using an intermediate build, include SHA): 3.0.1
Context
This impact the content of some of the prototypes in openstudio-standards.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the setDesignMinimumZoneVentilationEfficiency behavior and the translation logic in src/energyplus/ForwardTranslator/ForwardTranslateSizingZone.cpp around lines 289-295. Compare how the Sizing:Zone and Controller:MechanicalVentilation objects use DesignSpecification:ZoneAirDistribution, using related issue #3898 and openstudio-standards context to define the intended separation before identifying the required API and translation changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100