NatLabRockies / NatLabRockies/OpenStudio
Improve logic in resolveMatchedSurfaceConstructionConflicts
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
We need to add logic to resolveMatchedSurfaceConstructionConflicts so that we repeatably solve conflicts. We should default to either the floor or ceiling winning by default and some scheme for walls. Also, internal source constructions should win over regular constructions.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at resolveMatchedSurfaceConstructionConflicts and trace its callers and the data representing floors, ceilings, walls, internal source constructions, and regular constructions. Define and document a deterministic priority scheme for each conflict category, then add or run the relevant conflict-resolution tests if the surrounding code identifies them. Done means repeated resolution produces the same result and follows the agreed priorities.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100