NatLabRockies / NatLabRockies/OpenStudio
Outside Boundary Conditions not handled in DefaultConstructionSet_Impl::getDefaultConstruction
@DavidGoldwasser is already working on this.
Since Sep 18, 2020.
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
Issue overview
DefaultConstructionSet_Impl::getDefaultConstruction does not handle some potential Outside Boundary Condition, like GroundFCfactorMethod in particular. Perhaps there is a justification for this one I'm not seeing, but it seems you can assign a OS:Construction:CfactorUndergroundWall to the Ground Wall and OS:Construction:FfactorGroundFloor on a Ground floor on a construction set just fine.
Also not handled: Foundation (maybe needed/implementable), and these two I suppose have a good reason not to be included OtherSideCoefficients, OtherSideConditionsModel
Details
Environment
Some additional details about your environment for this issue (if relevant):
- Platform (Operating system, version): All
- Version of OpenStudio (if using an intermediate build, include SHA): develop 2aeb103bf2a9dc6db8ee53b917dded7ae22e24eb
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.