NatLabRockies / NatLabRockies/OpenStudio
UTF-16 gbXML files not handled correctly in some cases
Open
@joseph-robertson is already working on this.
Since Jul 20, 2020.
component - gbXML
severity - Normal Bug
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
See more information at https://github.com/NREL/OpenStudio/pull/3673
Need to ensure that OpenStudio correctly handles reading gbXML files in UTF-16 and UTF-8, need unit tests for each to read gbXML and convert to OSM. Need to verify that encoding matches actual xml contents using text editor. Also need to see if there are different byte orders (big endian/little endian) are used in UTF-16 in the wild.
If unit tests show the core correctly handles UTF-16 files then the remaining issue is in passing UTF-16 gbXML files to the embedded gbXML editor.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.