NatLabRockies / NatLabRockies/OpenStudio
Warning message when running measure test 'Cannot find current Workflow Step'
Open
@joseph-robertson is already working on this.
Since Jun 26, 2020.
component - Workflow
severity - Normal Bug
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
This error is logged in the following places:
- https://github.com/NREL/OpenStudio/blob/develop/src/measure/OSRunner.cpp#L196-L200
- https://github.com/NREL/OpenStudio/blob/develop/src/measure/OSRunner.cpp#L271-L275
It occurs when initializing runner = OpenStudio::Measure::OSRunner.new(OpenStudio::WorkflowJSON.new)
and then calling measure.run(model, runner, argument_map).
Results in warning 'Cannot find current Workflow Step'
The previous lines come with the template unit test files for new measures.
Seems like we could remove the warnings from OSRunner.cpp altogether, but here are some notes from @macumber :
id rather give the runner an extra flag like 'testingMode = true' than completely remove that check
then we could raise the warning to an error and not give the issue in testing mode
although measures using the runner would not be able to get the current step
so maybe a better method is one that automatically creates a workflow with the current measure
@shorowit
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.