NatLabRockies / NatLabRockies/OpenStudio
Fix DSOA related methods in ZoneHVACIdealAirLoadsAirSystem to conform to API
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
The ZoneHVACIdealAirLoadsAirSystem does not conform to other ModelObject API and is currently an odd duck.
Todo:
- Remove IDD Field for Design Specifcation Outdoor Air Object: this should be infered from the classic inheritance schema (zone -> spaces() -> spaceType)
- Remove ZoneHVACIdealLoadsAirSystem::setDesignSpecificationOutdoorAirObject
- [ ] Rename
ZoneHVACIdealLoadsAirSystem::designSpecificationOutdoorAirObjectto designSpecificationOutdoorAir to match other objects API (such as Space/SpaceType) - Modify implementation of
ZoneHVACIdealLoadsAirSystem::designSpecificationOutdoorAirto find the appropriate Optional DSOA based on thermalZone->spaces()->designSpecificationOutdoorAir, like it's currently done in the Forward Translator: ForwardTranslateZoneHVACIdealLoadsAirSystem.cpp#L178:L198
Found while answering on unmethours here: https://unmethours.com/question/30924/outside-air-ideal-loads/
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ZoneHVACIdealLoadsAirSystem.hpp and the existing designSpecificationOutdoorAirObject methods named in the issue. Compare the ForwardTranslateZoneHVACIdealLoadsAirSystem.cpp implementation at the referenced lines with Space and SpaceType APIs, then trace the thermalZone-to-spaces design-specification lookup. Done means the IDD field and setter are removed, the accessor is renamed and inferred consistently, and related code still conforms to the API.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100