NatLabRockies / NatLabRockies/OpenStudio

Fix DSOA related methods in ZoneHVACIdealAirLoadsAirSystem to conform to API

Open
#3,100 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

component - HVAC component - Model severity - Minor Bug
Dominant language
C++
Stars
646
Forks
237
Avg merge
3d 11h
Merged PRs (30d)
10

Description

The ZoneHVACIdealAirLoadsAirSystem does not conform to other ModelObject API and is currently an odd duck.

Todo:

  • Remove IDD Field for Design Specifcation Outdoor Air Object: this should be infered from the classic inheritance schema (zone -> spaces() -> spaceType)
  • Remove ZoneHVACIdealLoadsAirSystem::setDesignSpecificationOutdoorAirObject
  • [ ] Rename ZoneHVACIdealLoadsAirSystem::designSpecificationOutdoorAirObject to designSpecificationOutdoorAir to match other objects API (such as Space/SpaceType)
  • Modify implementation of ZoneHVACIdealLoadsAirSystem::designSpecificationOutdoorAir to find the appropriate Optional DSOA based on thermalZone->spaces()->designSpecificationOutdoorAir, like it's currently done in the Forward Translator: ForwardTranslateZoneHVACIdealLoadsAirSystem.cpp#L178:L198

Found while answering on unmethours here: https://unmethours.com/question/30924/outside-air-ideal-loads/

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with ZoneHVACIdealLoadsAirSystem.hpp and the existing designSpecificationOutdoorAirObject methods named in the issue. Compare the ForwardTranslateZoneHVACIdealLoadsAirSystem.cpp implementation at the referenced lines with Space and SpaceType APIs, then trace the thermalZone-to-spaces design-specification lookup. Done means the IDD field and setter are removed, the accessor is renamed and inferred consistently, and related code still conforms to the API.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.