NatLabRockies / NatLabRockies/OpenStudio
Additional logic needed for Surface::setSpace
Open
Nobody has claimed this yet.
component - Model
severity - Normal Bug
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
If surface is in a space and you call setSpace on another space we need to do some more checks (e.g. for adjacencies, make sure subsurfaces referenced by shading groups are still ok).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Surface::setSpace entry point and trace how a surface is moved between spaces. Inspect adjacency handling and the subsurfaces referenced by shading groups; done means those relationships remain valid after changing spaces.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100